Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix concurrency issues on Package.swift #826

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

jbelkins
Copy link
Contributor

Issue #

awslabs/aws-sdk-swift#1759

Description of changes

Modify the package dependencies by evaluating a block containing dependency logic during package initialization, rather than by defining then calling a function that modifies package.

This corrects issues flagged by Swift 6 language mode.

Scope

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jbelkins jbelkins merged commit 7b75b71 into main Sep 18, 2024
27 checks passed
@jbelkins jbelkins deleted the jbe/swift_6_compatible_manifest branch September 18, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants